Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

First version of the hit based CA tracker for ALICE3 IT/OT#15066

Merged
njacazio merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
mpuccio:mp-branch-1mpuccio/AliceO2:mp-branch-1Copy head branch name to clipboard
Feb 16, 2026
Merged

First version of the hit based CA tracker for ALICE3 IT/OT#15066
njacazio merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
mpuccio:mp-branch-1mpuccio/AliceO2:mp-branch-1Copy head branch name to clipboard

Conversation

@mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Feb 12, 2026

No description provided.

@mpuccio
ITSTracking: change visibility of methods
2d0b9e3 
Change TimeFrame prepareClusters method visibility to protected
Add computeTracksMClabels method to Tracker class
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Feb 12, 2026
Merged
@alibuild alibuild mentioned this pull request Feb 12, 2026
Closed
@mpuccio
Copy link
Contributor Author

mpuccio commented Feb 12, 2026

Please when/if you merge do not squash

@alibuild
Copy link
Collaborator

alibuild commented Feb 12, 2026 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for 92ededd at 2026-02-13 08:43:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:82:41: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:84:42: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:86:39: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:88:41: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:90:52: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:92:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:94:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:96:49: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:98:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:102:43: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:104:39: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:106:47: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:108:58: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:110:57: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:112:54: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:114:58: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:116:44: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:118:57: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:120:59: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:124:44: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:126:58: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:128:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:130:51: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:132:49: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:134:60: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:136:52: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:138:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:140:53: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:142:50: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:144:53: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:146:53: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:148:53: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:150:54: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:152:45: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:154:51: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:188:43: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@mpuccio
Copy link
Contributor Author

mpuccio commented Feb 16, 2026

@fprino : the ITS part is minimal and discussed already with Felix, please have a look
@njacazio : can you have a look and merge if it is fine with you?

njacazio
njacazio reviewed Feb 16, 2026
View reviewed changes
Copy link
Collaborator

@njacazio njacazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @mpuccio tagging also @fcolamar and @altsybee

@njacazio njacazio merged commit 3e68768 into AliceO2Group:dev Feb 16, 2026
13 of 14 checks passed
@njacazio
Copy link
Collaborator

njacazio commented Feb 16, 2026

Indeed I squashed by mistake when merging. @mpuccio shall we revert and reopen?

@mpuccio
Copy link
Contributor Author

mpuccio commented Feb 16, 2026 •
edited
Loading

@f3sch , can we live with this squashed? The changes in ITS are really minimal

@f3sch
Copy link
Collaborator

f3sch commented Feb 16, 2026

@njacazio reverting would create a much bigger mess, so no let's leave it like this. But in the future, we have to be careful if a PR touches production code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes

@fprino fprino fprino approved these changes

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mpuccio @alibuild @njacazio @f3sch @fprino
Morty Proxy This is a proxified and sanitized view of the page, visit original site.