Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Trying to get ROOT 6.32.0 to digest the type#13310

Merged
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
ktf:pr13310ktf/AliceO2:pr13310Copy head branch name to clipboard
Jul 20, 2024
Merged

Trying to get ROOT 6.32.0 to digest the type#13310
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
ktf:pr13310ktf/AliceO2:pr13310Copy head branch name to clipboard

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jul 19, 2024

Trying to get ROOT 6.32.0 to digest the type

@ktf ktf requested a review from shahor02 as a code owner July 19, 2024 09:56
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

shahor02
shahor02 previously approved these changes Jul 19, 2024
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Jul 19, 2024

Error while checking build/O2/fullCI for 5f3709f at 2024-07-19 13:50:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:34:14: error: expected '(' for function-style cast or type construction
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:36:14: error: expected '(' for function-style cast or type construction
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:38:14: error: expected '(' for function-style cast or type construction
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:40:14: error: expected '(' for function-style cast or type construction
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:50:27: error: program scope variable must reside in global or constant address space
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:51:26: error: program scope variable must reside in global or constant address space
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:52:26: error: program scope variable must reside in global or constant address space
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:53:26: error: program scope variable must reside in global or constant address space
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:60:29: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:61:30: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:65:31: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:69:32: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:73:31: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:77:26: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:80:30: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:90:10: error: field has incomplete type 'o2::dataformats::AbstractRef<25, 5, 2>::Base_t' (aka 'void')
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/GlobalTrackID.h:89:79: error: use of undeclared identifier 'getSource'; did you mean 'Source'?
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/GlobalTrackID.h:90:77: error: too few arguments to function call, single argument 'i' was not specified
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/GlobalTrackID.h:103:63: error: use of undeclared identifier 'getSource'; did you mean 'Source'?
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/GlobalTrackID.h:105:45: error: use of undeclared identifier 'getIndex'
ninja: build stopped: subcommand failed.

Full log here.

@ktf
Copy link
Member Author

ktf commented Jul 19, 2024

Updated... Apparently OpenCL does not like uint{} and wants uint()...

@alibuild
Copy link
Collaborator

alibuild commented Jul 19, 2024

Error while checking build/O2/fullCI for 55a9793 at 2024-07-19 14:39:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:34:14: error: expected '(' for function-style cast or type construction
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:36:14: error: expected '(' for function-style cast or type construction
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:38:14: error: expected '(' for function-style cast or type construction
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:40:14: error: expected '(' for function-style cast or type construction
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:50:27: error: program scope variable must reside in global or constant address space
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:51:26: error: program scope variable must reside in global or constant address space
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:52:26: error: program scope variable must reside in global or constant address space
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:53:26: error: program scope variable must reside in global or constant address space
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:60:29: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:61:30: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:65:31: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:69:32: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:73:31: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:77:26: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:80:30: error: argument may not have 'void' type
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/common/include/CommonDataFormat/AbstractRef.h:90:10: error: field has incomplete type 'o2::dataformats::AbstractRef<25, 5, 2>::Base_t' (aka 'void')
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/GlobalTrackID.h:89:79: error: use of undeclared identifier 'getSource'; did you mean 'Source'?
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/GlobalTrackID.h:90:77: error: too few arguments to function call, single argument 'i' was not specified
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/GlobalTrackID.h:103:63: error: use of undeclared identifier 'getSource'; did you mean 'Source'?
/sw/SOURCES/O2/13310-slc8_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/GlobalTrackID.h:105:45: error: use of undeclared identifier 'getIndex'
ninja: build stopped: subcommand failed.

Full log here.

@ktf ktf merged commit 7458f67 into AliceO2Group:dev Jul 20, 2024
@ktf
Copy link
Member Author

ktf commented Jul 20, 2024

Merging this. Not sure it will fix the ROOT 6.32.0 issue, however it should not harm and to my vertically scrolling eyes the code is more obvious.

@ktf ktf deleted the pr13310 branch July 20, 2024 05:55
@ktf ktf mentioned this pull request Jul 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktf @alibuild @shahor02
Morty Proxy This is a proxified and sanitized view of the page, visit original site.