[FOCAL-98] Optimizing the hit processing in FOCAL#13297
Merged
mfasDa merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Jul 19, 2024
Merged
[FOCAL-98] Optimizing the hit processing in FOCAL#13297mfasDa merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
mfasDa merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Collaborator
mfasDa
requested changes
Jul 19, 2024
Collaborator
mfasDa
left a comment
There was a problem hiding this comment.
Only small naming change, otherwise ready to merge
Use std::unordered_map with hit key based on hit coordinates in order to have fast hash-based hit search.
mfasDa
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizing the hit processing in the FOCAL detector by using hash ID and inverse std::unordered_map instead of the linear for the hit which can be exhausting.