Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Pythia8 seeding improvements#13281

Merged
sawenzel merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
sawenzel:swenzel/pythia8seedingsawenzel/AliceO2:swenzel/pythia8seedingCopy head branch name to clipboard
Jul 10, 2024
Merged

Pythia8 seeding improvements#13281
sawenzel merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
sawenzel:swenzel/pythia8seedingsawenzel/AliceO2:swenzel/pythia8seedingCopy head branch name to clipboard

Conversation

@sawenzel
Copy link
Collaborator

@sawenzel sawenzel commented Jul 8, 2024

This commit improves the seeding of Pythia8 in O2. The seeding...

(a) ... is now done as part of the object's Init function automatically.
Users are no longer required to provide own seeding logic,
which can significantly simplify the setup.
By default, Pythia8 will seed against ROOT TRandom::GetSeed,
which is itself set to values of the command line option --seed,
used in the o2-sim ... or o2-sim-dpl-eventgen execetuables (which
are the 2 places undertaking event generation). This setup guarantees
that

```
o2-sim-dpl-eventgen --generator pythiapp --seed x
```
will result in different event sequences when x changes.

(b) Users can simply set the seed via a setInitialSeed function
on the GeneratorPythia8 object. The function must be called before
GeneratorPythia8::Init is executed. So calling it right after the constructor
is fine.

Example code (e.g., inside user Generator macro) is:

```
auto mygen = new o2::eventgen::GeneratorPythia8();
long seed = atol(getenv(ALIEN_PROC_ID));
if(!mygen->setInitialSeed(seed)) {
  std::cerr << "seeding failed";
}
```

In result, the commit leads to a simplification of the Pythia8 setup also in GeneratorFactory.

@sawenzel
Pythia8 seeding improvements
75f9579 
This commit improves the seeding of Pythia8 in O2.
The seeding...

(a) ... is now done as part of the object's Init function automatically.
    Users are no longer required to provide own seeding logic,
    which can significantly simplify the setup.
    By default, Pythia8 will seed against ROOT TRandom::GetSeed,
    which is itself set to values of the command line option `--seed`,
    used in the o2-sim ... or o2-sim-dpl-eventgen execetuables (which
    are the 2 places undertaking event generation). This setup guarantees
    that

    ```
    o2-sim-dpl-eventgen --generator pythiapp --seed x
    ```
    will result in different event sequences when x changes.

(b) Users can simply set the seed via a `setInitialSeed` function
    on the GeneratorPythia8 object. The function must be called before
    GeneratorPythia8::Init is executed. So calling it right after the constructor
    is fine.

    Example code (e.g., inside user Generator macro) is:

    ```
    auto mygen = new o2::eventgen::GeneratorPythia8();
    long seed = atol(getenv(ALIEN_PROC_ID));
    if(!mygen->setInitialSeed(seed)) {
      std::cerr << "seeding failed";
    }
    ```

In result, the commit leads to a simplification of the Pythia8
setup also in GeneratorFactory.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@alibuild
Copy link
Collaborator

alibuild commented Jul 8, 2024 •
edited
Loading

Error while checking build/O2/fullCI for 75f9579 at 2024-07-08 17:48:

++ rsync -a '--exclude=**/.git' --delete --delete-excluded /sw/SOURCES/O2DPG/13281-slc8_x86-64/0/ /sw/slc8_x86-64/O2DPG/13281-slc8_x86-64-local1/
++ mkdir -p etc/modulefiles
++ alibuild-generate-module --bin
BUILD_REQUIRES=alibuild-recipe-tools defaults-release
FULL_BUILD_REQUIRES=defaults-release alibuild-recipe-tools
DEFAULTS_RELEASE is a build_requires. Skipping loading the associated module.
++ cat
++ mkdir -p /sw/slc8_x86-64/O2DPG/13281-slc8_x86-64-local1/etc/modulefiles
++ rsync -a --delete etc/modulefiles/ /sw/slc8_x86-64/O2DPG/13281-slc8_x86-64-local1/etc/modulefiles

Full log here.

@sawenzel sawenzel merged commit 4179712 into AliceO2Group:dev Jul 10, 2024
sawenzel added a commit to sawenzel/O2DPG that referenced this pull request Jul 10, 2024
@sawenzel
Remove superfluous seeding code for GeneratorPythia8 generators
976b89b 
This commit harmonizes the seeding procedure of generators based
on o2::eventgen::GeneratorPythia8, following a development done in O2
(AliceO2Group/AliceO2#13281)

In principle, o2::eventgen::GeneratorPythia8 now performs it's own
seeding within the Init function. This seeding makes sure
to integrate with the `--seed` command line option of our event generation
executable.

The commit:
* Removes seeding code in O2DPG when it would override the default
  behaviour from O2.

* Uses a new dedicated function `setInitialSeed` instead of manipulating
  Pythia8 with config strings (in situations in which the user
  targets seeding based on ALIEN_PROC_ID for instance).

* Ensures that event generation becomes more repeatable in situations
  when the same `--seed` is given to the event generation executable.
  This may help to debug crashes on the GRID etc.
sawenzel added a commit to sawenzel/O2DPG that referenced this pull request Jul 10, 2024
@sawenzel
Remove superfluous seeding code for GeneratorPythia8 generators
5eeeec4 
This commit harmonizes the seeding procedure of generators based
on o2::eventgen::GeneratorPythia8, following a development done in O2
(AliceO2Group/AliceO2#13281)

In principle, o2::eventgen::GeneratorPythia8 now performs it's own
seeding within the Init function. This seeding makes sure
to integrate with the `--seed` command line option of our event generation
executable.

The commit:
* Removes seeding code in O2DPG when it would override the default
  behaviour from O2.

* Uses a new dedicated function `setInitialSeed` instead of manipulating
  Pythia8 with config strings (in situations in which the user
  targets seeding based on ALIEN_PROC_ID for instance).

* Ensures that event generation becomes more repeatable in situations
  when the same `--seed` is given to the event generation executable.
  This may help to debug crashes on the GRID etc.
@fcatalan92 fcatalan92 mentioned this pull request Jul 10, 2024
Open
sawenzel added a commit to sawenzel/O2DPG that referenced this pull request Jul 11, 2024
@sawenzel
Remove superfluous seeding code for GeneratorPythia8 generators
f82b452 
This commit harmonizes the seeding procedure of generators based
on o2::eventgen::GeneratorPythia8, following a development done in O2
(AliceO2Group/AliceO2#13281)

In principle, o2::eventgen::GeneratorPythia8 now performs it's own
seeding within the Init function. This seeding makes sure
to integrate with the `--seed` command line option of our event generation
executable.

The commit:
* Removes seeding code in O2DPG when it would override the default
  behaviour from O2.

* Uses a new dedicated function `setInitialSeed` instead of manipulating
  Pythia8 with config strings (in situations in which the user
  targets seeding based on ALIEN_PROC_ID for instance).

* Ensures that event generation becomes more repeatable in situations
  when the same `--seed` is given to the event generation executable.
  This may help to debug crashes on the GRID etc.
sawenzel added a commit to sawenzel/O2DPG that referenced this pull request Jul 11, 2024
@sawenzel
Remove superfluous seeding code for GeneratorPythia8 generators
81f99b3 
This commit harmonizes the seeding procedure of generators based
on o2::eventgen::GeneratorPythia8, following a development done in O2
(AliceO2Group/AliceO2#13281)

In principle, o2::eventgen::GeneratorPythia8 now performs it's own
seeding within the Init function. This seeding makes sure
to integrate with the `--seed` command line option of our event generation
executable.

The commit:
* Removes seeding code in O2DPG when it would override the default
  behaviour from O2.

* Uses a new dedicated function `setInitialSeed` instead of manipulating
  Pythia8 with config strings (in situations in which the user
  targets seeding based on ALIEN_PROC_ID for instance).

* Ensures that event generation becomes more repeatable in situations
  when the same `--seed` is given to the event generation executable.
  This may help to debug crashes on the GRID etc.
@alcaliva alcaliva added the async-2024-pp-apass1 Request porting to async-2024-pp-apass1 label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel

Assignees

No one assigned

Labels

async-2024-pp-apass1 Request porting to async-2024-pp-apass1

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sawenzel @alibuild @alcaliva
Morty Proxy This is a proxified and sanitized view of the page, visit original site.