Development of the generic format API by matthiasrichter · Pull Request #110 · AliceO2Group/AliceO2

matthiasrichter · Apr 14, 2016

I have collapsed my development of a mockup for the format API, the final data header is not part of this development but is in the fork of @mkrzwic . We will soon merge it.

The update concludes the discussion in the CWG4 meeting

Introducing template parameters for the header message and the payload message. Correcting some typos.

The test is to first extend a compilation check and can be later extended to a unit test

Creating new module 'DataFormats' on top level. The recent development regarding data formats goes into DataFormats/Generic.

The original header definition has served as basis for the discussion, the final definition has been developed elsewhere and is soon to be merged. The very early definition is temporarily kept for the unit test.

MohammadAlTurany · Apr 19, 2016

Hi Matthias,
The test crashes with:

* thread #1: tid = 0x597d9, 0x0000000100001f7f testMessageList`void print_list<AliceO2::Format::messageList<TestMsg, SimpleHeader_t> >(list=<unavailable>, hdrsel=<unavailable>) + 191 at testMessageList.cxx:77, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x0000000100001f7f testMessageList`void print_list<AliceO2::Format::messageList<TestMsg, SimpleHeader_t> >(list=<unavailable>, hdrsel=<unavailable>) + 191 at testMessageList.cxx:77
   74          it != list.end();
   75          ++it) {
   76       // the iterator defines a conversion operator to the header type
-> 77       std::cout << static_cast<typename ListType::header_type>(it) << std::end;
   78       // dereferencing of the iterator gives the payload
   79       std::cout << *it << std::end;
   80     }

matthiasrichter · Apr 19, 2016

Hi Mohammad,
seems that I have been using static_cast in an inappropriate way to invoke the type cast operator. On some architectures it works, but it's undefined, what takes precedence.

I have pushed a fix to my dev branch and it looks like it automatically appears in the PR (cool ;-). Could you please try again.

Ciao
Matthias

MohammadAlTurany · Apr 19, 2016

Hi Matthias,

Still crashing on MAC,

Process 85821 launched: '/Users/turany/fairsoft/releases/src/AliceO2/build/bin/testMessageList' (x86_64)
simple list:
Header ID: 1
Process 85821 stopped
* thread #1: tid = 0x6dab31, 0x000000010000267f testMessageList`void print_list<AliceO2::Format::messageList<unsigned char const*, SimpleHeader_t> >(list=<unavailable>, hdrsel=<unavailable>) + 191 at testMessageList.cxx:78, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x000000010000267f testMessageList`void print_list<AliceO2::Format::messageList<unsigned char const*, SimpleHeader_t> >(list=<unavailable>, hdrsel=<unavailable>) + 191 at testMessageList.cxx:78
   75          ++it) {
   76       // the iterator defines a conversion operator to the header type
   77       typename ListType::header_type hdr = it;
-> 78       std::cout << hdr << std::endl;
   79       // dereferencing of the iterator gives the payload
   80       std::cout << *it << std::endl;
   81     }

MohammadAlTurany · Apr 19, 2016

Hi Matthias,

it crashes in the line:

stream << "Header Specification: " << std::hex << header.specification;

When using clang, writing to output stream caused segmentation violation because the stream object was not returned by the operator which has been used just before. Adding also some other return statements (though irrelevant for the crash). Crash log * thread #1: tid = 0x597d9, 0x0000000100001f7f testMessageList`void print_list<AliceO2::Format::messageList<TestMsg, SimpleHeader_t> >(list=<unavailable>, hdrsel=<unavailable>) + 191 at testMessageList.cxx:77, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0) frame #0: 0x0000000100001f7f testMessageList`void print_list<AliceO2::Format::messageList<TestMsg, SimpleHeader_t> >(list=<unavailable>, hdrsel=<unavailable>) + 191 at testMessageList.cxx:77 74 it != list.end(); 75 ++it) { 76 // the iterator defines a conversion operator to the header type -> 77 std::cout << static_cast<typename ListType::header_type>(it) << std::end; 78 // dereferencing of the iterator gives the payload 79 std::cout << *it << std::end; 80 }

matthiasrichter · Apr 19, 2016

Hi Mohammad,
in the end, it was much simpler: a missing return statement in the custom ostream operator<<. Fix is pushed, the previous one is removed. I tested also with clang. I hope its working now.

Ciao
Matthias

MohammadAlTurany · Apr 20, 2016

Hi Matthias,
Thanks, now it works! it is merged with the dev.
best,
Mohammad

matthiasrichter · Apr 20, 2016

Hi Mohammad,
very good. But I just noticed that the first attempt also is merged now, even though it was not part of the PR.

Cheers
Matthias

…genessTables.h (AliceO2Group#110)

matthiasrichter added 12 commits April 6, 2016 09:17

adding a first draft of the in-memory primitive structures

10f2b10

Updating the primitive data headers

65f9256

The update concludes the discussion in the CWG4 meeting

first draft of messageList class and iterator API

7301a7d

Extending message list class to allow two template parameters

4cdf46e

Introducing template parameters for the header message and the payload message. Correcting some typos.

Adding test executable for message_list template

41ea1d6

The test is to first extend a compilation check and can be later extended to a unit test

adding format test to build

df1a68d

Introducing conditional search in the list iterator

54d5749

Using a mockup of the list element selector

42e76a3

Adjusting new development to the proposed directory structure

e03f1f7

Creating new module 'DataFormats' on top level. The recent development regarding data formats goes into DataFormats/Generic.

Rename unit test exe and add as test to cmake configuration

64e43d1

adding documentation

59891b2

Adding notice about usage of the data format header in the unit test

11423a9

The original header definition has served as basis for the discussion, the final definition has been developed elsewhere and is soon to be merged. The very early definition is temporarily kept for the unit test.

matthiasrichter force-pushed the dev branch from d525a09 to 2cf7d88 Compare April 19, 2016 21:17

MohammadAlTurany closed this Apr 20, 2016

knopers8 added a commit to knopers8/AliceO2 that referenced this pull request Sep 7, 2020

Fix MySQL database connect function header (AliceO2Group#110)

12f6613

EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021

Add Lifetime Cut to lambdakzeroanalysis - Add DistOverTotMom to Stran…

d4966c0

…genessTables.h (AliceO2Group#110)

alibuild pushed a commit to alibuild/AliceO2 that referenced this pull request Nov 11, 2025

Merge pull request AliceO2Group#110 from alibuild/alibot-cleanup-14795

3a77f95

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Development of the generic format API#110

Development of the generic format API#110
matthiasrichter wants to merge 13 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
matthiasrichter:devmatthiasrichter/AliceO2:devCopy head branch name to clipboard

matthiasrichter commented Apr 14, 2016

Uh oh!

MohammadAlTurany commented Apr 19, 2016 •

edited

Loading

Uh oh!

matthiasrichter commented Apr 19, 2016

Uh oh!

MohammadAlTurany commented Apr 19, 2016

Uh oh!

MohammadAlTurany commented Apr 19, 2016

Uh oh!

matthiasrichter commented Apr 19, 2016

Uh oh!

MohammadAlTurany commented Apr 20, 2016

Uh oh!

matthiasrichter commented Apr 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Search code, repositories, users, issues, pull requests...

Comments

Conversation

matthiasrichter commented Apr 14, 2016

Uh oh!

MohammadAlTurany commented Apr 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiasrichter commented Apr 19, 2016

Uh oh!

MohammadAlTurany commented Apr 19, 2016

Uh oh!

MohammadAlTurany commented Apr 19, 2016

Uh oh!

matthiasrichter commented Apr 19, 2016

Uh oh!

MohammadAlTurany commented Apr 20, 2016

Uh oh!

matthiasrichter commented Apr 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

MohammadAlTurany commented Apr 19, 2016 •

edited

Loading