Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

MCH: add (empty) error map to new clustering #10778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aphecetche merged 2 commits into from
Feb 16, 2023
Merged

MCH: add (empty) error map to new clustering #10778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d0e30
MCH: decrease default logging of new clustering
aphecetche Feb 15, 2023
5914933
MCH: add (empty) errorMap for new clustering
aphecetche Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 Detectors/MUON/MCH/Clustering/include/MCHClustering/ClusterConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ struct ClusterConfig {
debug = 0x3 ///< Ful details
};
VerboseMode fittingLog = no;
VerboseMode processingLog = info; // Global
VerboseMode processingLog = no;
VerboseMode padMappingLog = no;
VerboseMode groupsLog = no;
VerboseMode EMLocalMaxLog = no;
Expand Down
17 changes: 16 additions & 1 deletion 17 Detectors/MUON/MCH/Workflow/src/ClusterFinderGEMSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include "CommonUtils/ConfigurableParam.h"
#include "DataFormatsMCH/ROFRecord.h"
#include "DataFormatsMCH/Digit.h"
#include "MCHBase/ErrorMap.h"
#include "MCHBase/PreCluster.h"
#include "DataFormatsMCH/Cluster.h"
#include "MCHClustering/ClusterFinderOriginal.h"
Expand Down Expand Up @@ -171,6 +172,9 @@ class ClusterFinderGEMTask
delete mGEMDump;
mGEMDump = nullptr;
}
mErrorMap.forEach([](Error error) {
LOGP(warning, error.asString());
});
});
auto stop = [this]() {
/// close the output file
Expand Down Expand Up @@ -198,6 +202,8 @@ class ClusterFinderGEMTask
uint32_t iPreCluster = 0;

clusterROFs.reserve(preClusterROFs.size());
ErrorMap errorMap; // TODO: use this errorMap to score processing errors

for (const auto& preClusterROF : preClusterROFs) {
// LOG(info) << "processing interaction: time frame " << preClusterROF.getBCData().orbit << "...";
// GG infos
Expand Down Expand Up @@ -284,6 +290,13 @@ class ClusterFinderGEMTask
writeClusters(clusters, usedDigits);
}

// create the output message for clustering errors
auto& clusterErrors = pc.outputs().make<std::vector<Error>>(OutputRef{"clustererrors"});
errorMap.forEach([&clusterErrors](Error error) {
clusterErrors.emplace_back(error);
});
mErrorMap.add(errorMap);

LOGP(info, "Found {:4d} clusters from {:4d} preclusters in {:2d} ROFs",
clusters.size(), preClusters.size(), preClusterROFs.size());
}
Expand Down Expand Up @@ -318,6 +331,7 @@ class ClusterFinderGEMTask
int mode; ///< Original or GEM or both
ClusterDump* mGEMDump;
ClusterDump* mOriginalDump;
ErrorMap mErrorMap{}; ///< counting of encountered errors
std::chrono::duration<double> mTimeClusterFinder{}; ///< timer
};

Expand All @@ -331,7 +345,8 @@ o2::framework::DataProcessorSpec getClusterFinderGEMSpec(const char* specName)
InputSpec{"digits", "MCH", "PRECLUSTERDIGITS", 0, Lifetime::Timeframe}},
Outputs{OutputSpec{{"clusterrofs"}, "MCH", "CLUSTERROFS", 0, Lifetime::Timeframe},
OutputSpec{{"clusters"}, "MCH", "CLUSTERS", 0, Lifetime::Timeframe},
OutputSpec{{"clusterdigits"}, "MCH", "CLUSTERDIGITS", 0, Lifetime::Timeframe}},
OutputSpec{{"clusterdigits"}, "MCH", "CLUSTERDIGITS", 0, Lifetime::Timeframe},
OutputSpec{{"clustererrors"}, "MCH", "CLUSTERERRORS", 0, Lifetime::Timeframe}},
AlgorithmSpec{adaptFromTask<ClusterFinderGEMTask>()},
Options{
{"mch-config", VariantType::String, "", {"JSON or INI file with clustering parameters"}},
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.