Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Fix in stopping track accumulation when stat is ok#10733

Merged
martenole merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
shahor02:pr_fixTPCIntshahor02/AliceO2:pr_fixTPCIntCopy head branch name to clipboard
Feb 8, 2023
Merged

Fix in stopping track accumulation when stat is ok#10733
martenole merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
shahor02:pr_fixTPCIntshahor02/AliceO2:pr_fixTPCIntCopy head branch name to clipboard

Conversation

@shahor02
Copy link
Collaborator

@shahor02 shahor02 commented Feb 8, 2023

@martenole
Copy link
Contributor

Thanks @shahor02 but actually one should not break here in case additional ITS-TPC tracks are requested. The segfault occurred, because with the default settings ITS-TPC tracks are not requested. And in any case there must be a protection in case no ITS-TPC tracks are available for a given TF.
But if there are, then I don't stop even if a sufficient amount of statistics is already reached. Instead, I still process a certain number of ITS-TPC only tracks to get a more uniform phi coverage

@martenole martenole merged commit ea8fda3 into AliceO2Group:dev Feb 8, 2023
@shahor02 shahor02 deleted the pr_fixTPCInt branch February 13, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.