Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Residual aggregator output dir specified automatically #10245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martenole merged 1 commit into from
Nov 11, 2022
Merged

Residual aggregator output dir specified automatically #10245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 ...low/tpcinterpolationworkflow/include/TPCInterpolationWorkflow/TPCResidualAggregatorSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class ResidualAggregatorDevice : public o2::framework::Task
storeMetaFile = true;
}
if (!mWriteOutput && (outputDirConf != "none" || storeMetaFile)) {
LOGF(alarm, "File output is disabled, but output directory %s was specified and meta file storage is set to %i", outputDirConf, storeMetaFile);
LOGF(info, "File output is disabled, but output directory %s was specified and meta file storage is set to %i. No output file will be written", outputDirConf, storeMetaFile);
storeMetaFile = false;
}
mAggregator = std::make_unique<o2::tpc::ResidualAggregator>(minEnt);
Expand Down
19 changes: 16 additions & 3 deletions 19 prodtests/full-system-test/aggregator-workflow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,21 @@ if [[ "0$GEN_TOPO_VERBOSE" == "01" ]]; then
echo "CCDB_POPULATOR_UPLOAD_PATH = $CCDB_POPULATOR_UPLOAD_PATH" 1>&2
fi

# Additional settings for calibration workflows
if [[ -z $CALIB_DIR ]]; then CALIB_DIR=$FILEWORKDIR; fi # Directory where to store output from calibration workflows

# All meta files go into the same directory
if [[ -z $CALIB_METAFILES_DIR ]]; then
if [[ ! -z $CTF_METAFILES_DIR ]]; then
CALIB_METAFILES_DIR=$CTF_METAFILES_DIR
else
CALIB_METAFILES_DIR="/dev/null"
fi
fi

if [[ $RUNTYPE == "SYNTHETIC" ]]; then DISABLE_CALIB_OUTPUT="--disable-root-output"; fi


# Adding calibrations
EXTRA_WORKFLOW_CALIB=

Expand Down Expand Up @@ -174,9 +189,7 @@ if [[ $AGGREGATOR_TASKS == BARREL_TF ]] || [[ $AGGREGATOR_TASKS == ALL ]]; then
fi
# TPC
if [[ $CALIB_TPC_SCDCALIB == 1 ]]; then
# TODO: the residual aggregator should have --output-dir and --meta-output-dir defined
# without that the residuals will be stored in the local working directory (and deleted after a week)
add_W o2-calibration-residual-aggregator "--disable-root-input $ENABLE_TRACK_INPUT $CALIB_TPC_SCDCALIB_CTP_INPUT --output-type trackParams,unbinnedResid,binnedResid --autosave-interval $RESIDUAL_AGGREGATOR_AUTOSAVE"
add_W o2-calibration-residual-aggregator "--disable-root-input $DISABLE_CALIB_OUTPUT $ENABLE_TRACK_INPUT $CALIB_TPC_SCDCALIB_CTP_INPUT --output-dir $CALIB_DIR --meta-output-dir $CALIB_METAFILES_DIR --autosave-interval $RESIDUAL_AGGREGATOR_AUTOSAVE"
fi
if [[ $CALIB_TPC_VDRIFTTGL == 1 ]]; then
# options available via ARGS_EXTRA_PROCESS_o2_tpc_vdrift_tgl_calibration_workflow="--nbins-tgl 20 --nbins-dtgl 50 --max-tgl-its 2. --max-dtgl-itstpc 0.15 --min-entries-per-slot 1000 --time-slot-seconds 600 <--vdtgl-histos-file-name name> "
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.