[8.0-stable] Merge pull request #236 from AlchemyCMS/alchemy-config #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alchemy 8 changed how to stub the config from positional arguments to a hash (cherry picked from commit af96387)
In latest Rack unprocessable_entity is deprecated (cherry picked from commit c0c9d6a)
Instead of our own config we make use of the new `Alchemy::Configuration` introduced in Alchemy 8.0, which gives better DX. All exising config setters and getters are still working, but are deprecated. (cherry picked from commit 7c1e67a)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0-stable #242 +/- ##
=============================================
Coverage ? 98.62%
=============================================
Files ? 11
Lines ? 291
Branches ? 0
=============================================
Hits ? 287
Misses ? 4
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.0-stable:Questions ?
Please refer to the Backport tool documentation