Login, Signup and Password reset forms improvements #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a68cabf to
e49317d
Compare
3 tasks
Devise has a email presence validation, but allows to override it. We make it conditional by using the devise aithentication keys.
Turbo requires a 422 response in order to show validation errors.
We are using the resource_table partial
- Only shows locale select if many availabel locales exist - Set login and email fields to be required accordingly - Add autocomplete attribute where appropriate
- Require email / login field - Add proper autocomplete values
Require fields and add appropriate autocomplete values.
e49317d to
534b9fb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 98.52% 98.55% +0.02%
==========================================
Files 10 10
Lines 272 276 +4
==========================================
+ Hits 268 272 +4
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
534b9fb to
529aaac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements for the login, signup and password reset forms, which haven't got much love over the years.
Mostly this adds HTML validation and proper autocomplete values, which takes the forms into the 21st century.
Also the colors and logo get adjusted to match recent Alchemy 8 theme changes.