This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Add support for /data/GetNews#10
Open
kauffecup wants to merge 1 commit intoAlchemyAPI:masterAlchemyAPI/alchemyapi_node:masterfrom
Open
Add support for /data/GetNews#10kauffecup wants to merge 1 commit intoAlchemyAPI:masterAlchemyAPI/alchemyapi_node:masterfrom
kauffecup wants to merge 1 commit intoAlchemyAPI:masterAlchemyAPI/alchemyapi_node:masterfrom
Conversation
This change does the following:
- Add referenced endpoints for `/data/GetNews`
- Add method for `news` that takes start, end, timeSlice, maxResults, and q
- Add support for "GET" in analyze (might be a little hacky - just let me know)
- Replace manually building of query string to using the npm module qs - this supports nested JSON. For example `{ a: { b: 'c' } }` becomes `a.b=c` (necessary for the queries that Alchemey supports)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does the following:
/data/GetNewsnewsthat takes start, end, timeSlice, maxResults, and q{ a: { b: 'c' } }becomesa.b=c(necessary for the queries that Alchemey supports)