Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

New Excercises#30

Merged
Akuli merged 28 commits intoAkuli:masterAkuli/python-tutorial:masterfrom
georgerahul24:masterCopy head branch name to clipboard
Jul 30, 2021
Merged

New Excercises#30
Akuli merged 28 commits intoAkuli:masterAkuli/python-tutorial:masterfrom
georgerahul24:masterCopy head branch name to clipboard

Conversation

@georgerahul24
Copy link
Contributor

I had added some new exercises for if and for loops.
I will add more later

Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't create a new PR to fix these things. Just change this PR.

I would like some explanations to be written slightly differently, but I didn't include them in this review because I can change them myself.

basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
pallindrome_input=input("Type the number to check:") #to get the input from user
pallindrome_check=pallindrome_input[::-1] #Reverses the string
if pallindrome_input==pallindrome_check:
print(f"This number is a pallindrome")
Copy link
Owner

@Akuli Akuli Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent these with 4 spaces.

Your markdown list item (starting with 7.) is indented with 3 spaces. That too should be indented with 4 spaces, so you get 4 spaces for most lines and 4+4 spaces for indented code.

basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
basics/loops.md Outdated Show resolved Hide resolved
@georgerahul24
Copy link
Contributor Author

Thank you for the tips..
I will make the changes..

basics/loops.md Outdated Show resolved Hide resolved
basics/loops.md Outdated
1 2 3 4 5
```

6. Make a programme to get a pyramid like shown in the OUTPUT section where user can type the number of rows needed
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. Make a programme to get a pyramid like shown in the OUTPUT section where user can type the number of rows needed
6. Modify your program from the previous exercise to print this instead:

basics/loops.md Outdated Show resolved Hide resolved
basics/if.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
georgerahul24 and others added 4 commits July 14, 2021 01:18
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 georgerahul24 requested a review from Akuli July 13, 2021 20:13
basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
basics/handy-stuff-strings.md Outdated Show resolved Hide resolved
basics/loops.md Outdated Show resolved Hide resolved
georgerahul24 and others added 6 commits July 14, 2021 02:06
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
# Conflicts:
#	basics/handy-stuff-strings.md
basics/answers.md Outdated Show resolved Hide resolved
@georgerahul24 georgerahul24 requested a review from Akuli July 13, 2021 21:27
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for not giving up with this and updating it over and over again as I review it!

Also, sorry about the delay. I somehow missed your request for review.

basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
basics/answers.md Outdated Show resolved Hide resolved
georgerahul24 and others added 2 commits July 30, 2021 22:11
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
georgerahul24 and others added 4 commits July 30, 2021 22:12
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24
Copy link
Contributor Author

georgerahul24 commented Jul 30, 2021

Thanks a lot for helping me learn the process of adding PRs

@georgerahul24 georgerahul24 requested a review from Akuli July 30, 2021 16:45
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nits :)

basics/answers.md Outdated Show resolved Hide resolved
basics/handy-stuff-strings.md Outdated Show resolved Hide resolved
georgerahul24 and others added 2 commits July 31, 2021 00:48
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24 georgerahul24 requested a review from Akuli July 30, 2021 19:20
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Akuli Akuli merged commit 18c7cea into Akuli:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.