Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[sc-12339] fix importing cookie library, expose cookie related methods #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

[sc-12339] fix importing cookie library, expose cookie related methods #88

merged 4 commits into from
Jun 26, 2025

Conversation

haoAddsearch
Copy link
Collaborator

@haoAddsearch haoAddsearch commented Jun 26, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added methods to set and retrieve cookies directly from the client instance.

  • Chores

    • Updated the package version to 1.1.1.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 26, 2025 •
edited
Loading

Walkthrough

The changes include updating the package version in package.json, modifying the import style for the cookie module in src/cookie.ts to use named imports, and adding two new public methods, setCookie and getCookie, to the AddSearchClient class in src/index.ts for cookie manipulation.

Changes

File(s) Change Summary
package.json Incremented version from 1.1.0 to 1.1.1.
src/cookie.ts Changed cookie import from default to named imports of serialize and parse; updated calls accordingly.
src/index.ts Added setCookie and getCookie methods to AddSearchClient class, delegating to cookie utilities.

Sequence Diagram(s)

sequenceDiagram
    participant Client as AddSearchClient
    participant CookieUtil as cookie module

    Client->>CookieUtil: setCookie(cookieName, cookieValue, expireDays)
    Note right of CookieUtil: Sets the specified cookie

    Client->>CookieUtil: getCookie(cookieName)
    CookieUtil-->>Client: cookieValue or undefined
Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-26T12_04_31_237Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86e199a and 7f7f617.

📒 Files selected for processing (1)
  • src/cookie.ts (4 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/cookie.ts
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

italo-addsearch
italo-addsearch approved these changes Jun 26, 2025
View reviewed changes
src/cookie.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@haoAddsearch haoAddsearch merged commit 37d6561 into master Jun 26, 2025
2 checks passed
@haoAddsearch haoAddsearch deleted the sc-12339/fix-importing-cookie-library branch June 26, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@italo-addsearch italo-addsearch italo-addsearch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haoAddsearch @italo-addsearch
Morty Proxy This is a proxified and sanitized view of the page, visit original site.