Cm/dictionary version#1
Merged
tgoslee merged 6 commits intomainAdaGold/python-debugging:mainfrom Apr 28, 2021
cm/dictionary-versionAdaGold/python-debugging:cm/dictionary-versionCopy head branch name to clipboard
Merged
Cm/dictionary version#1tgoslee merged 6 commits intomainAdaGold/python-debugging:mainfrom cm/dictionary-versionAdaGold/python-debugging:cm/dictionary-versionCopy head branch name to clipboard
tgoslee merged 6 commits intomainAdaGold/python-debugging:mainfrom
cm/dictionary-versionAdaGold/python-debugging:cm/dictionary-versionCopy head branch name to clipboard
Conversation
anselrognlie
requested changes
Apr 28, 2021
Contributor
anselrognlie
left a comment
There was a problem hiding this comment.
The line alignment in order.py looks like it will align. Great!
In create_product we could mirror the class version a bit more closely. Pros: it would be a little trickier to notice, Cons: it would be a little trickier to notice! 😅
Also, could you please remove:
.pylintrc__init__.pyc
added 2 commits
April 28, 2021 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.