fix: close settings popup for non-Firefox browsers #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to dbc7296 in 1 minute and 17 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. src/settings/main.ts:11
- Draft comment:
Note: browser.runtime.reload() is called without await; ensure that subsequent window.close() executes as intended since reload may not be immediate. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
2. src/settings/main.ts:13
- Draft comment:
Suggestion: Verify that detectBrowser() reliably returns 'firefox' or another expected string to avoid unintended closures on unsupported browsers. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
3. src/settings/main.ts:8
- Draft comment:
Ensure that detectBrowser() returns a normalized (e.g., lowercase) value so the strict comparison with 'firefox' is reliable. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
Without seeing the implementation of detectBrowser(), I cannot verify if case normalization is actually needed. The function could already return normalized values. The comment is speculative - it assumes there might be a case sensitivity issue without evidence. This violates the rule about not making speculative comments.
The function could return inconsistent casing, making this a valid concern. Browser strings are notorious for inconsistency.
While browser string inconsistency is a real concern, we need actual evidence of a problem. The function could be well-designed to handle this already.
Delete the comment as it's speculative without evidence of an actual issue. We'd need to see detectBrowser()'s implementation to know if this is really needed.
4. src/settings/main.ts:14
- Draft comment:
Consider potential timing issues: calling browser.runtime.reload() and then immediately window.close() might be sensitive to race conditions. A short delay before closing the window might ensure the reload is properly initiated on Chromium-based browsers. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
Workflow ID: wflow_XQzDMwYqFHBxfhzP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Chromium-based browsers, the pop-up doesn't automatically close when the extension reloads, allowing users to click the save button multiple times and cause errors
Important
Close settings popup for non-Firefox browsers in
reloadExtension()inmain.ts.main.ts,reloadExtension()now closes the settings popup for non-Firefox browsers usingwindow.close().detectBrowser() !== 'firefox'.This description was created by
for dbc7296. It will automatically update as commits are pushed.