Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9e4dfee

Browse filesBrowse files
authored
maint: fix spelling errors (octokit#241)
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
1 parent bfb0977 commit 9e4dfee
Copy full SHA for 9e4dfee

File tree

Expand file treeCollapse file tree

3 files changed

+4
-4
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+4
-4
lines changed

‎CONTRIBUTING.md

Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,6 @@ Only one version number is bumped at a time, the highest version change trumps t
6666
Besides publishing a new version to npm, semantic-release also creates a git tag and release
6767
on GitHub, generates changelogs from the commit messages and puts them into the release notes.
6868

69-
Before the publish it runs the `npm run build` script which creates a `pkg/` folder with distributions for browsers, node and Typescript definitions. The contents of the `pkg/` folder are published to the npm registry.
69+
Before the publish it runs the `npm run build` script which creates a `pkg/` folder with distributions for browsers, node and TypeScript definitions. The contents of the `pkg/` folder are published to the npm registry.
7070

7171
If the pull request looks good but does not follow the commit conventions, use the <kbd>Squash & merge</kbd> button.

‎src/types.ts

Copy file name to clipboardExpand all lines: src/types.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type CommonAppStrategyOptions = {
1616
clientId: string;
1717
clientSecret: string;
1818
request?: OctokitTypes.RequestInterface;
19-
onTokenCreated?: OnToketCreatedCallback;
19+
onTokenCreated?: OnTokenCreatedCallback;
2020
};
2121

2222
type CommonOAuthAppStrategyOptions = {
@@ -121,7 +121,7 @@ export interface GitHubAppAuthInterface {
121121

122122
// INTERNAL STATE
123123

124-
type OnToketCreatedCallback = (
124+
type OnTokenCreatedCallback = (
125125
authentication:
126126
| OAuthAppAuthentication
127127
| GitHubAppAuthentication

‎test/octokit.test.ts

Copy file name to clipboardExpand all lines: test/octokit.test.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ test("Sets clientId/clientSecret as Basic auth for /authentication/{clientId}/*
165165
expect(data).toEqual({ ok: true });
166166
});
167167

168-
test("Sets no auth auth for OAuth Web flow requests", async () => {
168+
test("Sets no auth for OAuth Web flow requests", async () => {
169169
const matchCreateTokenRequest: MockMatcherFunction = (url, options) => {
170170
expect(url).toEqual("https://github.com/login/oauth/access_token");
171171
// @ts-ignore

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.