some cleaning of screen5 #1899
Open
some cleaning of screen5 #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
here are the tests: if you look at the screening test, you can see that the sqrt(sqrt(x)) change introduces roundoff diffs. http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2025-12-16-001/test_screening_C.html For a few tests, the burning takes an additional few steps, giving seemingly large diffs in the output. But I think that the diffs are okay. We might be able to write our own qdrt() function that does the automatic differentiation more efficiently. |
Member
Author
|
this speeds things up a lot. I need to update the benchmarks though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will change answers to roundoff because we do sqrt(sqrt(x)) instead of pow(x, 0.25)