Fix sync for restarted instances #2437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcwu
suggested changes
May 18, 2025
|
|
||
| snprintf(id0, sizeof(id0), "%s/id:000000,*", qd_path); | ||
|
|
||
| if (glob(id0, 0, NULL, &glob_result) == 0 && glob_result.gl_pathc == 1 && |
There was a problem hiding this comment.
ah yes! had never worked with glob() before ...
| } else { | ||
|
|
||
| // something went wrong - this cannot be right, mabye the instance is | ||
| // restarting, skip |
There was a problem hiding this comment.
don't forget to free namelist, goto close_sync probably better.
src/afl-fuzz-run.c
Outdated
| min_accept = 0; | ||
| ck_write(id_fd, &min_accept, sizeof(u32), qd_synced_path); | ||
| close(id_fd); | ||
| continue; |
There was a problem hiding this comment.
how about no "continue"; set next_min_accept=0 and let it continue the below sync?
There was a problem hiding this comment.
then I need another jump point and adding that for just one jump source - I rather do the write instead there.
kcwu
reviewed
May 18, 2025
src/afl-fuzz-run.c
Outdated
| @@ -816,6 +816,7 @@ void sync_fuzzers(afl_state_t *afl) { | ||
| stat(glob_result.gl_pathv[0], &st) == 0) { | ||
|
|
||
| // we found exactly one "id:000000,*" file and obtained its mtime | ||
| globfree(glob_result); |
|
looks good to me now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.