Code modernization #207
Open
Code modernization #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RelBreR
approved these changes
Oct 10, 2024
|
This looks really good! Hopefully, it's merged. |
RelBreR
approved these changes
Dec 18, 2024
|
Let me review this :) |
Merged
|
Hey, I resolved a conflict I had with the latest updates from your repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to modernize the library's source code in the following pull request.
Why?
I needed to extend the
ImplersonateManagercode in a given project. I had no problems doing this, but the project implies 100% code coverage, which was impossible due to the extension of the manager. It has no argument types, so when extending, I can't put them in either.What have I done?
Hope this PR helps and gets merged 😃