Allow for setting the redirect leave URL when impersonating a user #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello ! I'm waiting for some feedback about this feature |
|
I would absolutely love to see this merged. @MarceauKa what kind of feedback are you looking for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability of setting the redirect leave URL when starting to impersonate a user. It does this via a query parameter, and sets in the session if it is present. When leaving the impersonation it checks if it is present in the session and uses this as a redirect url.
I needed this feature for a project for a client I am working on. Hopefully you also find it useful and it can get merged to the package.