Issue 6248 - fix fanalyzer warnings #6253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81f23ad to
392fefb
Compare
droideck
approved these changes
Jul 11, 2024
| /* referral list is already an array of berval* */ | ||
| if (value) | ||
| slapi_entry_attr_replace(e, cgas->attr_name, (struct berval **)*value); | ||
| slapi_entry_attr_replace(e, cgas->attr_name, *(struct berval ***)value); |
There was a problem hiding this comment.
We still have a warning here:
stack-based buffer over-read [CWE-126] [-Wanalyzer-out-of-bounds]
There was a problem hiding this comment.
Will something like this calm it?
/* referral list is already an array of berval* */
if (value) {
struct berval **referral_list = *(struct berval ***)value;
if (referral_list) {
slapi_entry_attr_replace(e, cgas->attr_name, referral_list);
} else {
slapi_entry_attr_set_charptr(e, cgas->attr_name, "");
}
} else {
slapi_entry_attr_set_charptr(e, cgas->attr_name, "");
}
break;There was a problem hiding this comment.
FYI: I got 10 warnings for libglobs.c, I suspect it is again the false positive about following different branches in different switches
|
A bit funny: previous @droideck remark make me realize that I got different result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change remove all gcc -fanalyzer warnings.
Number of them are not that interesting (False/positive due to some limts of the analyzer and some possible crashes when running out of memory.
But some of these warnings where real concerns.
Issue #6248
Reviewed by: @droideck (Thanks!)