Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

progier389
Copy link
Contributor

@progier389 progier389 commented Jun 10, 2024

CI test indexes/test_long_rdn sometime crashes
The issue is that a data returned by dblayer_bulk_nextdata iterator is wrongly freed
The fix is to avoid freeing the data

Issue: #6207

Reviewed by: @droideck (Thanks!)

@progier389 progier389 added this to the 2.5 milestone Jun 10, 2024
@progier389 progier389 self-assigned this Jun 10, 2024
@progier389 progier389 linked an issue Jun 10, 2024 that may be closed by this pull request
Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@progier389 progier389 merged commit f2e581b into 389ds:main Jun 11, 2024
@tbordaz
Copy link
Contributor

tbordaz commented Jun 11, 2024

LGTM as well.
Just a minor comment. Sometime the function _entryrdn_dup_rdn_elem is called before _entryrdn_resolve_redirect so that this later is called with '1' (canfree).
For example here or here

In the opposite here or here

You may use the same way of calling everywhere.

@progier389
Copy link
Contributor Author

I agree it would make things more readable, but on the other side it will duplicate the rdn_elem when it is not really needed (then you will have to take care to free the duplicated data) and I would rather prefer to avoid stressing malloc/free when it is not useful.

progier389 added a commit that referenced this pull request Feb 19, 2025
CI test indexes/test_long_rdn sometime crashes
The issue is that a data returned by dblayer_bulk_nextdata iterator is wrongly freed
The fix is to avoid freeing the data

Issue: #6207

Reviewed by: @droideck (Thanks!)

(cherry picked from commit f2e581b)
progier389 added a commit that referenced this pull request Feb 19, 2025
CI test indexes/test_long_rdn sometime crashes
The issue is that a data returned by dblayer_bulk_nextdata iterator is wrongly freed
The fix is to avoid freeing the data

Issue: #6207

Reviewed by: @droideck (Thanks!)

(cherry picked from commit f2e581b)
progier389 added a commit that referenced this pull request Feb 19, 2025
CI test indexes/test_long_rdn sometime crashes
The issue is that a data returned by dblayer_bulk_nextdata iterator is wrongly freed
The fix is to avoid freeing the data

Issue: #6207

Reviewed by: @droideck (Thanks!)

(cherry picked from commit f2e581b)
@progier389 progier389 deleted the i6207 branch May 20, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random crash in test_long_rdn CI test

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.