Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

droideck
Copy link
Member

@droideck droideck commented Jun 5, 2024

Description: Add HAProxy trusted IP address multi-valued attribute to cn=schema in 01core389.ldif

Related: #6188

Reviewed by: ?

Description: Add HAProxy trusted IP address multi-valued attribute
to cn=schema in 01core389.ldif

Related: 389ds#6188

Reviewed by: ?
@droideck droideck force-pushed the haproxy-minor-fixes branch from 4887859 to 7d9aefc Compare June 5, 2024 05:13
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
FYI: At first glance I was a bit surprised to not see the new attribute added in any objectClasses but none of the other config attributes is in nsslapdConfig. They rely on the fact that cn=config is an extensibleObject. So this change looks fine

@droideck droideck merged commit bb887aa into 389ds:main Jun 6, 2024
droideck added a commit that referenced this pull request Jun 6, 2024
Description: Add HAProxy trusted IP address multi-valued attribute
to cn=schema in 01core389.ldif

Related: #6188

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jun 6, 2024
Description: Add HAProxy trusted IP address multi-valued attribute
to cn=schema in 01core389.ldif

Related: #6188

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jun 6, 2024
Description: Add HAProxy trusted IP address multi-valued attribute
to cn=schema in 01core389.ldif

Related: #6188

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this pull request Jun 6, 2024
Description: Add HAProxy trusted IP address multi-valued attribute
to cn=schema in 01core389.ldif

Related: #6188

Reviewed by: @progier389 (Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.