Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

vashirov
Copy link
Member

… '/var/cache/dnf/metadata_lock.pid'`

Bug Description:
There is an intermittent issue during container startup in our CI:

[Errno 2] No such file or directory: '/var/cache/dnf/metadata_lock.pid'
Error: Process completed with exit code 1.

systemd is not fully initialized when a second command runs and expects a pid file to be available.
The script should wait until systemctl is-system-running is successful.

Fix Description:
Add a check for systemctl is-system-running.

Fixes: #6189

Reviewed by: ???

@progier389
Copy link
Contributor

FYIL I see an unusual failure:
https://github.com/389ds/389-ds-base/actions/runs/9316761322/job/25646058151?pr=6190
But not sure it could be related to your change or if it is a spurious problem with the test vm

@vashirov
Copy link
Member Author

What test is this exactly? For me it shows "This job failed" but no output.
My change fixes the issue where the tests would not even start.

@vashirov
Copy link
Member Author

So far I filed #6192 and #6193

@progier389
Copy link
Contributor

What test is this exactly? For me it shows "This job failed" but no output. My change fixes the issue where the tests would not even start.

It is LMDB referint_plugin test and I see the same thing (This job failed) as if the job failed from the very beginning (before logging anything .

@vashirov
Copy link
Member Author

Looks like a GH issue, it passed in my fork https://github.com/vashirov/389-ds-base/actions/runs/9316760802/job/25646060484

Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@progier389
Copy link
Contributor

And kudos for having fixed that painful issue ! 🥇

Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, looks great! Ack, from me, too!

… '/var/cache/dnf/metadata_lock.pid'`

Bug Description:
There is an intermittent issue during container startup in our CI:
```
[Errno 2] No such file or directory: '/var/cache/dnf/metadata_lock.pid'
Error: Process completed with exit code 1.
```

`systemd` is not fully initialized when a second command runs and expects
a pid file to be available.
The script should wait until `systemctl is-system-running` is successful.

Fix Description:
Add a check for `systemctl is-system-running`.

Fixes: 389ds#6189

Reviewed by: @progier389, @droideck (Thanks!)
@vashirov vashirov merged commit 78efaab into 389ds:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI tests fail with [Errno 2] No such file or directory: '/var/cache/dnf/metadata_lock.pid'

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.