fix(plugin): use compiler.webpack when possible #1884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the fix (f7ee30b) that resolved the same issue on v15.
Context
When there are different versions of Webpack used in a repo (for example, one is added to the repo and the other one is coming from a node module) Webpack loses its reference to the
Compilerobject. The plugins no longer need torequire('webpack')in Webpack 5. It's recommended to usecompiler.webpackwhere possible.Related comments of the Webpack authors/contributors in a similar issue: webpack/webpack#12606 (comment), webpack/webpack#12606 (comment)
Additional
I had to use
ts-ignorebecause the branch useswebpack@4types.Related to #1781