build(deps-dev): bump serialize-javascript from 1.3.0 to 2.1.2 #10914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Dec 9, 2019
@posva it's done. Sincerely I tried to found a reason for the pinned version of |
|
It's fine for webpack. It will be updated at a different time |
13 tasks
|
@posva any idea about when it's gonna be released? |
Closed
This was referenced Dec 13, 2019
|
Hey @mateusvelleda, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)Other information:
Since I couldn't find the reason for pinning
webpackat shakir-abdo@bb0aab6 I just upgrade it. I've done it due towebpack#terser-webpack-plugin#serialize-javascriptthat would keep the vulnerable version in the deps