Use the whole string instead of a single line for template match#431
Merged
sporkmonger merged 2 commits intosporkmonger:mainsporkmonger/addressable:mainfrom Jul 30, 2022
ojab:ct-_do_not_parse_multiline_stringsojab/addressable:ct-_do_not_parse_multiline_stringsCopy head branch name to clipboard
Merged
Use the whole string instead of a single line for template match#431sporkmonger merged 2 commits intosporkmonger:mainsporkmonger/addressable:mainfrom ojab:ct-_do_not_parse_multiline_stringsojab/addressable:ct-_do_not_parse_multiline_stringsCopy head branch name to clipboard
sporkmonger merged 2 commits intosporkmonger:mainsporkmonger/addressable:mainfrom
ojab:ct-_do_not_parse_multiline_stringsojab/addressable:ct-_do_not_parse_multiline_stringsCopy head branch name to clipboard
Conversation
houndci-bot
reviewed
Sep 2, 2021
a2f32c7 to
22af13f
Compare
Contributor
Author
|
Marking as ready for review because |
therabidbanana
approved these changes
Sep 2, 2021
Collaborator
therabidbanana
left a comment
There was a problem hiding this comment.
Seems like a good change - supporting multi line strings was definitely not intentional 👍
|
|
||
| describe "#to_regexp" do | ||
| it "does not match the first line of multiline strings" do | ||
| uri = "https://www.example.com/bar" |
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiline strings shouldn't pass the validation if a single line matches.