Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Octavia: Support listener tags #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

lingxiankong
Copy link
Contributor

@coveralls
Copy link

coveralls commented Sep 11, 2021

Coverage Status

Coverage remained the same at 79.821% when pulling 4e6e00c on lingxiankong:listener-tag into 3b820fa on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 11, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor Author

@jtopjian This PR is ready for review

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lingxiankong Thanks! Just one small doc fix and this is good to go.

openstack/loadbalancer/v2/listeners/doc.go Outdated Show resolved Hide resolved
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 14, 2021

Build failed.

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@jtopjian
Copy link
Contributor

I think the OpenLab error is ignorable.

@jtopjian jtopjian merged commit eed3c29 into gophercloud:master Sep 14, 2021
@lingxiankong
Copy link
Contributor Author

Thanks @jtopjian

May I know when the next release is scheduled?

@lingxiankong lingxiankong deleted the listener-tag branch September 14, 2021 20:58
@jtopjian
Copy link
Contributor

@lingxiankong releases are generally ad-hoc. There aren't any other PRs in queue, so I've just created a v0.21.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.