Consolidate metadata types and expose OnUpdateCallback#852
Merged
Consolidate metadata types and expose OnUpdateCallback#852
Conversation
emilbonnek
suggested changes
Jul 21, 2022
emilbonnek
left a comment
There was a problem hiding this comment.
Works for me and provides a smoother typesafe story :)
Only got a tiny thing with currentFile not being nullable as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata types were duplicated as
Metadata(not exported) andJSZipMetadata(exported, and missingnulltype forcurrentFile).This PR gets rid of
Metadataand consolidates underJSZipMetadata.From #851