Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix some Documentation things#12199

Merged
vkarpov15 merged 13 commits intoAutomattic:masterAutomattic/mongoose:masterfrom
hasezoey:fixDocshasezoey/mongoose:fixDocsCopy head branch name to clipboard
Aug 9, 2022
Merged

Fix some Documentation things#12199
vkarpov15 merged 13 commits intoAutomattic:masterAutomattic/mongoose:masterfrom
hasezoey:fixDocshasezoey/mongoose:fixDocsCopy head branch name to clipboard

Conversation

@hasezoey
Copy link
Copy Markdown
Collaborator

@hasezoey hasezoey commented Aug 2, 2022

Summary

This PR does:

  • fix index (home page) footer Sponsor text
  • fix index (home page) header size
  • enhance handling of badly formatted @see tags
  • fix badly formatted @see tags
  • move styles from api_split.pug into api.css
  • remove file track.pug (because empty)
  • change list text for enterprise.md to be indented to be properly formatted
  • fix code in headers (markdown only applies if a new empty line separates html and markdown)
  • add padding for list elements in migrating_to_6
  • remove one TOC from schematypes.md

Copy link
Copy Markdown
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just 1 question/comment

docs/migrating_to_6.md Outdated Show resolved Hide resolved
Copy link
Copy Markdown
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just marking this as "request changes" to show that it's already been reviewed

@hasezoey
Copy link
Copy Markdown
Collaborator Author

hasezoey commented Aug 4, 2022

Force pushed to drop the original migrating_to_6.md header change commit and added a new c34c076

@hasezoey hasezoey requested a review from vkarpov15 August 4, 2022 09:24
Copy link
Copy Markdown
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.5.2 milestone Aug 9, 2022
@vkarpov15 vkarpov15 merged commit 7b41035 into Automattic:master Aug 9, 2022
@hasezoey hasezoey deleted the fixDocs branch August 9, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.