Python Dependencies
Unlike our frontend JavaScript story, where we're generally very happy pulling in dependencies, we're much more conservative on the backend. Any dependency we pull in might require us to eventually (temporarily) fork and vendor it if the upstream project no longer supports our version of Python.
Additionally, all these dependencies run on the server, making them riskier as they have direct access to customer data if they turn out to be malicious.
Adding or Updating a Dependency
Any new dependency needs to be thoroughly reviewed and approved by owners-python-build. This group is already automatically tagged in your PR to sentry
or getsentry
as soon as you edit relevant files. For other repos you might need to do it manually.
Dependencies must:
- be on internal pypi
- not be added to repos as non-specifier requirements (see sentry's
tools/lint_requirements.py
)
To add or update a dependency:
- Clone https://github.com/getsentry/pypi/.
cd
into your clone and runpython3 -m add_pkg PKGNAME
(orpython3 -m add_pkg PKGNAME==PKGVERSION
if you want a version other than the latest).- Commit the resulting changes to a branch, open a PR in
getsentry/pypi
, and tag someone on your team (any engineer can approve PRs on this repo). - Once your PR is merged, go back to the main repo whose dependencies you want to change (
sentry
,getsentry
, etc.). - In that repo, add to or update the dependency in
pyproject.toml
(orrequirements*.txt
if the repo isn't usinguv
yet).
- In sentry, you can do this with the bump-version action.
- Click the Run workflow dropdown.
- Fill in your package name and version.
- Click the Run workflow button.
Note
Dependencies should pinned with lower bounds >=
, to encourage updating to latest versions.
- Run
make freeze-requirements
(oruv lock
). You might need to wait a few minutes for the changes togetsentry/pypi
to be deployed before this will work without erroring. - Commit your changes (which should consist of changes to both one of the
requirements
files and its corresponding lockfile) to a branch and open a PR in the relevant repo. If it's not obvious, explain why you're adding or updating the dependency. Tagowners-python-build
if they haven't already been auto-tagged. - Merge your PR, pull
master
, and rundevenv sync
.
Depending on forks
If you need to make modifications to a dependency and need to deploy the result before it is accepted upstream, you must fork the dependency and publish it to pypi and internal pypi.
- Fork into the
getsentry
organization and make your changes. - Add craft configuration to publish to pypi+internal pypi (example).
- Add the dependency to your repository.
Unclear?
If you have questions about dependencies, ask owners-python-build or in #discuss-dev-infra.
Our documentation is open source and available on GitHub. Your contributions are welcome, whether fixing a typo (drat!) or suggesting an update ("yeah, this would be better").