feat(admin): Add option to delete user from the user's page #13554

famfo-cb · 2026-07-21 13:30:59 +02:00

famfo-cb commented

2026-07-21 13:30:59 +02:00

Admins may be sent the URL to an abusive profile. Instead of manually
going back to the admin user list and searching for the user, this
enables them to directly delete users from their profile view.

This is a port of:
Codeberg-Infrastructure/forgejo@d119860a6f

Release notes

Features
- PR: feat(admin): Add option to delete user from the user's page

Admins may be sent the URL to an abusive profile. Instead of manually going back to the admin user list and searching for the user, this enables them to directly delete users from their profile view. This is a port of: https://codeberg.org/Codeberg-Infrastructure/forgejo/commit/d119860a6fad707785fea434386841d5c64835c5  ## Release notes  - Features - [PR](https://codeberg.org/forgejo/forgejo/pulls/13554): feat(admin): Add option to delete user from the user's page

famfo-cb added 1 commit

2026-07-21 13:30:59 +02:00

feat(admin): Add option to delete user from the user's page

testing / semgrep/ci (pull_request) Successful in 14s

Details

testing / frontend-checks (pull_request) Successful in 53s

Details

testing / backend-checks (pull_request) Successful in 3m17s

Details

testing / test-remote-cacher (valkey) (pull_request) Has been skipped

Details

testing / test-remote-cacher (garnet) (pull_request) Has been skipped

Details

testing / test-e2e (pull_request) Successful in 22m54s

Details

testing / test-mysql (pull_request) Successful in 24m46s

Details

testing / test-sqlite (pull_request) Successful in 41m41s

Details

testing / test-pgsql (pull_request) Successful in 45m32s

Details

issue-labels / backporting (pull_request_target) Has been skipped

Details

issue-labels / cascade (pull_request_target) Has been skipped

Details

issue-labels / release-notes (pull_request_target) Successful in 23s

Details

requirements / merge-conditions (pull_request) Failing after 14s

Details

testing / test-unit (pull_request) Successful in 5m41s

Details

testing / test-remote-cacher (redis) (pull_request) Successful in 4m10s

Details

testing / security-check (pull_request) Successful in 6m3s

Details

1681fdcd18

Admins may be sent the URL to an abusive profile. Instead of manually
going back to the admin user list and searching for the user, this
enables them to directly delete users from their profile view.

This is a port of:
d119860a6f

famfo-cb requested reviews from Beowulf, Gusted, ashimokawa

2026-07-21 13:31:00 +02:00

Gusted reviewed

2026-07-22 00:41:50 +02:00

templates/user/profile.tmpl

					
				@ -92,2 +92,4 @@

				</div>

				{{if $.IsAdmin}}

					<div class="ui g-modal-confirm delete modal" id="delete-user">

This is a old dialog modal. Also probably best if there's a single template for this. As it's and should be the same as the one in the admin page.

tests/integration/admin_user_test.go

					
				@ -76,9 +76,17 @@ func TestAdminViewUser(t *testing.T) {

					req := NewRequest(t, "GET", "/admin/users/1")

Would say this also deserves a E2E test merely to confirm:

modal opens
pressing delete indeed deletes the user and redirects to /admin/... page.

Would say this also deserves a E2E test merely to confirm: 1. modal opens 2. pressing delete indeed deletes the user and redirects to `/admin/...` page.

Gusted added the

labels

2026-07-22 00:42:04 +02:00

Gusted commented

2026-07-22 00:43:06 +02:00

CI failure unrelated, likely flaky but haven't seen this one before.

forgejo-release-notes-assistant commented

2026-07-22 01:11:53 +02:00

Where does that come from?

The following is a preview of the release notes for this pull request, as they will appear in the upcoming release. They are derived from the content of the `release-notes/13554.md` file, if it exists, or the title of the pull request. They were also added at the bottom of the description of this pull request for easier reference.

This message and the release notes originate from a call to the release-notes-assistant.

@@ -5,2 +5,10 @@
 This is a port of:
 https://codeberg.org/Codeberg-Infrastructure/forgejo/commit/d119860a6fad707785fea434386841d5c64835c5
+
+<!--start release-notes-assistant-->
+
+## Release notes
+<!--URL:https://codeberg.org/forgejo/forgejo-->
+- Features
+  - [PR](https://codeberg.org/forgejo/forgejo/pulls/13554): <!--number 13554 --><!--line 0 --><!--description ZmVhdChhZG1pbik6IEFkZCBvcHRpb24gdG8gZGVsZXRlIHVzZXIgZnJvbSB0aGUgdXNlcidzIHBhZ2U=-->feat(admin): Add option to delete user from the user's page<!--description-->
+<!--end release-notes-assistant-->

Release notes

Features
- PR: feat(admin): Add option to delete user from the user's page

<details> <summary>Where does that come from?</summary> The following is a preview of the release notes for this pull request, as they will appear in the upcoming release. They are derived from the content of the `release-notes/13554.md` file, if it exists, or the title of the pull request. They were also added at the bottom of the description of this pull request for easier reference. This message and the release notes originate from a call to the [release-notes-assistant](https://code.forgejo.org/forgejo/release-notes-assistant). ```diff @@ -5,2 +5,10 @@ This is a port of: https://codeberg.org/Codeberg-Infrastructure/forgejo/commit/d119860a6fad707785fea434386841d5c64835c5 + + + +## Release notes + +- Features + - [PR](https://codeberg.org/forgejo/forgejo/pulls/13554): feat(admin): Add option to delete user from the user's page + ``` </details>  ## Release notes  - Features - [PR](https://codeberg.org/forgejo/forgejo/pulls/13554): feat(admin): Add option to delete user from the user's page

testing / semgrep/ci (pull_request) Successful in 14s

Details

testing / frontend-checks (pull_request) Successful in 53s

Required

Details

testing / backend-checks (pull_request) Successful in 3m17s

Required

Details

testing / test-remote-cacher (valkey) (pull_request) Has been skipped

Details

testing / test-remote-cacher (garnet) (pull_request) Has been skipped

Details