Message 57177 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gvanrossum
Recipients	brett.cannon, christian.heimes, facundobatista, georg.brandl, guillaumegirard, gvanrossum
Date	2007-11-06.19:10:04
SpamBayes Score	0.35293582
Marked as misclassified	No
Message-id	<1194376204.36.0.627339998478.issue1293@psf.upfronthosting.co.za>
In-reply-to

Content
I see several problems with this, but there's light at the end of the tunnel. (1) Don't use s#; it will allow null bytes in the string, which we don't want. (2) Put the entire trailing slash removal inside #ifdef MS_WINDOWS. (3) Careful! It seems the code you wrote would transform "C:/" into "C:" which isn't the same thing (the latter refers to the current directory on the C drive, while the former is the root of the C drive).

I see several problems with this, but there's light at the end of the
tunnel.

(1) Don't use s#; it will allow null bytes in the string, which we don't
want.

(2) Put the entire trailing slash removal inside #ifdef MS_WINDOWS.

(3) Careful!  It seems the code you wrote would transform "C:/" into
"C:" which isn't the same thing (the latter refers to the current
directory on the C drive, while the former is the root of the C drive).

History
Date	User	Action	Args
2007-11-06 19:10:04	gvanrossum	set	spambayes_score: 0.352936 -> 0.35293582 recipients: + gvanrossum, brett.cannon, georg.brandl, facundobatista, christian.heimes, guillaumegirard
2007-11-06 19:10:04	gvanrossum	set	spambayes_score: 0.352936 -> 0.352936 messageid: <1194376204.36.0.627339998478.issue1293@psf.upfronthosting.co.za>
2007-11-06 19:10:04	gvanrossum	link	issue1293 messages
2007-11-06 19:10:04	gvanrossum	create