Message 349860 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	nanjekyejoannah
Recipients	eric.snow, nanjekyejoannah, serhiy.storchaka
Date	2019-08-16.13:23:10
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1565961791.0.0.986064453311.issue37872@roundup.psfhosted.org>
In-reply-to

Content
Relevant comment from @gnprice. I think it would be better to make that as a separate change. This style where they're block-local is the way the existing code works, which keeps the diff simple. It's also the way that every use of _Py_IDENTIFIER in this file works. So I think the cleanest way to change the style would be to sweep through this whole file (or more) in one PR, separate from any substantive changes.

Relevant comment from @gnprice.



I think it would be better to make that as a separate change. This style where they're block-local is the way the existing code works, which keeps the diff simple.

It's also the way that every use of _Py_IDENTIFIER in this file works. So I think the cleanest way to change the style would be to sweep through this whole file (or more) in one PR, separate from any substantive changes.

History
Date	User	Action	Args
2019-08-16 13:23:11	nanjekyejoannah	set	recipients: + nanjekyejoannah, eric.snow, serhiy.storchaka
2019-08-16 13:23:11	nanjekyejoannah	set	messageid: <1565961791.0.0.986064453311.issue37872@roundup.psfhosted.org>
2019-08-16 13:23:10	nanjekyejoannah	link	issue37872 messages
2019-08-16 13:23:10	nanjekyejoannah	create