Message 324101 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	izbyshev
Recipients	benjamin.peterson, berker.peksag, izbyshev, serhiy.storchaka
Date	2018-08-25.21:05:49
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1535231149.7.0.56676864532.issue34504@psf.upfronthosting.co.za>
In-reply-to

Content
The argument of PySequence_Check() is dereferenced at https://github.com/python/cpython/blob/5f79b50763d687aeeed8edcb4efcc7ac9f8fa186/Objects/abstract.c#L1511 and then checked for NULL. Reported by Svace static analyzer. Since other PySomething_Check() functions seem to expect a non-NULL argument, I suggest to remove the NULL check instead of moving it.

The argument of PySequence_Check() is dereferenced at https://github.com/python/cpython/blob/5f79b50763d687aeeed8edcb4efcc7ac9f8fa186/Objects/abstract.c#L1511 and then checked for NULL.

Reported by Svace static analyzer.

Since other PySomething_Check() functions seem to expect a non-NULL argument, I suggest to remove the NULL check instead of moving it.

History
Date	User	Action	Args
2018-08-25 21:05:49	izbyshev	set	recipients: + izbyshev, benjamin.peterson, berker.peksag, serhiy.storchaka
2018-08-25 21:05:49	izbyshev	set	messageid: <1535231149.7.0.56676864532.issue34504@psf.upfronthosting.co.za>
2018-08-25 21:05:49	izbyshev	link	issue34504 messages
2018-08-25 21:05:49	izbyshev	create